Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Kubernetes recommended labels to resources #596

Merged
merged 10 commits into from
Feb 5, 2020
Merged

Adding Kubernetes recommended labels to resources #596

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a5da07
Added some basic labels to the resource deployments
Cottonglow Jan 13, 2020
62a3593
Merge master from kedacore and updated labels for the new files
Cottonglow Jan 30, 2020
afc9ec0
Corrected the formatting for deploy file
Cottonglow Jan 31, 2020
b59e4ab
Updated versions to 1.1.0
Cottonglow Feb 3, 2020
d89ecb9
Resolve merge
Cottonglow Feb 3, 2020
d8821e4
Merge branch 'master' of https://github.com/kedacore/keda
Cottonglow Feb 3, 2020
ea41605
Updated Makefile to substitute version in version.go
Cottonglow Feb 4, 2020
373f40a
Revert version change in go file and use IMAGE_TAG instead of new VER…
Cottonglow Feb 4, 2020
afd9de9
Updated release process for the new labels
Cottonglow Feb 4, 2020
f142d68
Update HPA to reference the ScaledObject in the part-of label
Cottonglow Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update HPA to reference the ScaledObject in the part-of label
  • Loading branch information
@Cottonglow
Cottonglow committed Feb 5, 2020
commit f142d68690f62e42264542ad9a9fef80deb4283d
2 changes: 1 addition & 1 deletion pkg/controller/scaledobject/scaledobject_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ func (r *ReconcileScaledObject) newHPAForScaledObject(logger logr.Logger, scaled
labels := map[string]string{
"app.kubernetes.io/name": getHpaName(deploymentName),
"app.kubernetes.io/version": version.Version,
"app.kubernetes.io/part-of": deploymentName,
"app.kubernetes.io/part-of": scaledObject.GetName(),
"app.kubernetes.io/managed-by": "keda-operator",
}

Expand Down