Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update PR template with checkbox for core dataset contribution #891

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

merelcht
Copy link
Member

Description

Added a checkbox to the PR form to remind creators that core dataset contributions need a TSC vote.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@merelcht merelcht self-assigned this Oct 15, 2024
@merelcht merelcht changed the title Update PR template with checkbox for core dataset contribution chore: Update PR template with checkbox for core dataset contribution Oct 15, 2024
Copy link
Member

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment that doesnt really matter, but approved!

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

merelcht and others added 2 commits October 15, 2024 14:10
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht enabled auto-merge (squash) October 15, 2024 13:43
@merelcht merelcht merged commit 1039f35 into main Oct 15, 2024
42 of 43 checks passed
@merelcht merelcht deleted the update-git-pr-form branch October 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants