-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docs project for Kedro-Viz #1586
Conversation
…onf.py work and shields Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
I've added myself and @astrojuanlu to this PR to work on getting it complete to build a set of Viz docs. I'm wondering if it should be against |
See https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing.html#implicit-targets Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing so far, thank you!
A couple of comments/questions:
- You've included the custom CSS but the preview link doesn't look anything like the current Kedro docs. Do we have to do something else to make that work?
- Should we add an very short intro page, similar to the one Kedro has?
Yeah, I dunno. It's not a strong area of my skillset. But I did the wrong thing in making that dependency because ultimately the CSS will be down to your work on kedro-org/kedro#3016 so we should plumb those together. |
Yes, that would be great. We can add it into the |
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Fixed 👍🏽 |
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
OK, fixed for those comments. I'd like to release this if possible so we can hook it up to RTD subprojects builds and have a proper What will this take @astrojuanlu ? Is it as simple as merging into If we do this it means we can:
I'd like to avoid indexing the new subproject docs for now though, so once we do start publishing, we will need to adjust the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side this is good to go! After this is merged, I'll re-enable pull request builds on RTD, and we can keep iterating
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
This reverts commit 6448804.
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Vladimir <vladimir_nikolic@external.mckinsey.com>
I've copied the navigation from kedro and added the shared css in the layout as well. The only thing that is missing is the link to dataset docs for now. Let me know if you want me to revert it. |
This is great @vladimir-mck and I'm merging now! |
Description
Part of the ongoing work to enable a documentation subproject for Kedro-Viz. See #1524 for more details (and the parent ticket over in the Framework project for an overview).
Development notes
Added a sphinx project with basic styling. It needs
robots.txt
, heap script, shields, styling and loads more. It has a basic information architecture, links to Kedro docs (not datasets yet) and images.QA notes
Checklist
RELEASE.md
file