Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docs project for Kedro-Viz #1586

Merged
merged 18 commits into from
Oct 19, 2023
Merged

Create docs project for Kedro-Viz #1586

merged 18 commits into from
Oct 19, 2023

Conversation

stichbury
Copy link
Contributor

@stichbury stichbury commented Oct 17, 2023

Description

Part of the ongoing work to enable a documentation subproject for Kedro-Viz. See #1524 for more details (and the parent ticket over in the Framework project for an overview).

Development notes

Added a sphinx project with basic styling. It needs robots.txt, heap script, shields, styling and loads more. It has a basic information architecture, links to Kedro docs (not datasets yet) and images.

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

…onf.py work and shields

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@stichbury
Copy link
Contributor Author

I've added myself and @astrojuanlu to this PR to work on getting it complete to build a set of Viz docs. I'm wondering if it should be against develop rather than main.

tynandebold and others added 6 commits October 17, 2023 20:56
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu
Copy link
Member

@astrojuanlu astrojuanlu marked this pull request as ready for review October 18, 2023 07:16
@astrojuanlu astrojuanlu changed the title [Draft, no review yet] Create docs project for Kedro-Viz Create docs project for Kedro-Viz Oct 18, 2023
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing so far, thank you!

A couple of comments/questions:

  • You've included the custom CSS but the preview link doesn't look anything like the current Kedro docs. Do we have to do something else to make that work?
  • Should we add an very short intro page, similar to the one Kedro has?

@stichbury
Copy link
Contributor Author

stichbury commented Oct 18, 2023

  • You've included the custom CSS but the preview link doesn't look anything like the current Kedro docs. Do we have to do something else to make that work?

Yeah, I dunno. It's not a strong area of my skillset. But I did the wrong thing in making that dependency because ultimately the CSS will be down to your work on kedro-org/kedro#3016 so we should plumb those together.

@stichbury
Copy link
Contributor Author

stichbury commented Oct 18, 2023

  • Should we add an very short intro page, similar to the one Kedro has?

Yes, that would be great. We can add it into the index.md rather than make a new page, perhaps. I'll make a commit and feel free to edit it.

stichbury and others added 2 commits October 18, 2023 10:07
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu
Copy link
Member

You've included the custom CSS but the preview link doesn't look anything like the current Kedro docs. Do we have to do something else to make that work?

Fixed 👍🏽

docs/source/conf.py Outdated Show resolved Hide resolved
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@stichbury
Copy link
Contributor Author

OK, fixed for those comments.

I'd like to release this if possible so we can hook it up to RTD subprojects builds and have a proper docs.kedro.org/<subfolder> for it (if not stable then at least as a latest).

What will this take @astrojuanlu ? Is it as simple as merging into main.

If we do this it means we can:

I'd like to avoid indexing the new subproject docs for now though, so once we do start publishing, we will need to adjust the robots.txt for the docs subdomain @tynandebold

Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side this is good to go! After this is merged, I'll re-enable pull request builds on RTD, and we can keep iterating

stichbury and others added 5 commits October 19, 2023 11:34
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
This reverts commit 6448804.
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Vladimir <vladimir_nikolic@external.mckinsey.com>
@vladimir-mck
Copy link
Contributor

I've copied the navigation from kedro and added the shared css in the layout as well. The only thing that is missing is the link to dataset docs for now. Let me know if you want me to revert it.

@stichbury
Copy link
Contributor Author

This is great @vladimir-mck and I'm merging now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants