Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create custom 404 page for documentation #2464

Closed
astrojuanlu opened this issue Mar 24, 2023 · 2 comments · Fixed by #2486
Closed

Create custom 404 page for documentation #2464

astrojuanlu opened this issue Mar 24, 2023 · 2 comments · Fixed by #2486
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature

Comments

@astrojuanlu
Copy link
Member

Currently we are not defining a custom 404, so the default Read the Docs page is shown instead. See for example https://docs.kedro.org/en/stable/get_started/new_project_NOT_FOUND.html

image

We could use https://pypi.org/project/sphinx-notfound-page/
@astrojuanlu astrojuanlu added Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature labels Mar 24, 2023
@stichbury
Copy link
Contributor

Maybe when the branding is complete we could have a branded 404 page created for us?

astrojuanlu added a commit that referenced this issue Mar 31, 2023
@astrojuanlu
Add 404 page
7cdda28 
Fix gh-2464.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu astrojuanlu mentioned this issue Mar 31, 2023
Merged
5 tasks
@astrojuanlu
Copy link
Member Author

Maybe when the branding is complete we could have a branded 404 page created for us?

Totally (maybe with some playful joke of sorts), but in the meantime to avoid the weird Read the Docs default page, I've opened #2486, just because it was a 2 lines change and it improves the current situation.

astrojuanlu added a commit that referenced this issue Apr 3, 2023
@astrojuanlu
Add 404 page
3d14143 
Fix gh-2464.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu added a commit that referenced this issue Apr 3, 2023
@astrojuanlu
Add 404 page (#2486)
0497d45 
* Add 404 page

Fix gh-2464.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix broken link

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
MaximeSteinmetz pushed a commit to MaximeSteinmetz/kedro that referenced this issue Apr 3, 2023
@astrojuanlu @MaximeSteinmetz
Add 404 page (kedro-org#2486)
8279b19 
* Add 404 page

Fix kedro-orggh-2464.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix broken link

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: MaximeSteinmetz <maxime.steinmetz@gadz.org>
@astrojuanlu astrojuanlu mentioned this issue Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 404 page kedro-org/kedro
2 participants
@astrojuanlu @stichbury