Skip to content

Commit

Permalink
Merge pull request #569 from MartinEmrich/master
Browse files Browse the repository at this point in the history
Accept AWS ECR token for any AWS account ECR, might resolve #441
  • Loading branch information
rusenask committed Feb 9, 2021
2 parents 8063322 + 017ebba commit abdc757
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion extension/credentialshelper/aws/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (h *CredentialsHelper) GetCredentials(image *types.TrackedImage) (*types.Cr
"token": *ad.AuthorizationToken,
"registry": registry,
}).Debug("checking registry")
if u.Host == registry {
if strings.SplitN(u.Host,".",2)[1] == strings.SplitN(registry,".",2)[1] {
username, password, err := decodeBase64Secret(*ad.AuthorizationToken)
if err != nil {
return nil, fmt.Errorf("failed to decode authentication token: %s, error: %s", *ad.AuthorizationToken, err)
Expand Down

0 comments on commit abdc757

Please sign in to comment.