-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring the repository version and assuming SemVer means 10.4 -> 10.4.0 #80
Comments
see #81 worth noting I created the PR without compiling anything, its seems simple enough though that I might just get away with it |
Thanks, should work. We already had similar a issue with other versions where I thought I fixed it but apparently forgot about that |
See #82 which is to develop not master |
Tagged new patch release with the change https://github.com/rusenask/keel/releases/tag/0.4.5. Docker cloud builder should produce an image soon :) Thanks! |
Working for me now |
I use SemVer 'almost', but unless there is actual need for a patch version I omit it.
IME its just confusing and does not add any value, you either broke the contract or you didn't. I find that developers use minor and patch interchangeably on a whim and as a result they might as well be one number.
Well and I don't use 0 because 0 means nothing and if there is nothing why deploy.
Anyways can we just parse the version match which works fine but use the original value not the semverfied one? Without starting a religious war maybe?
The text was updated successfully, but these errors were encountered: