Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring the repository version and assuming SemVer means 10.4 -> 10.4.0 #80

Closed
stickycode opened this issue Aug 5, 2017 · 5 comments
Closed

Comments

@stickycode
Copy link
Contributor

I use SemVer 'almost', but unless there is actual need for a patch version I omit it.

IME its just confusing and does not add any value, you either broke the contract or you didn't. I find that developers use minor and patch interchangeably on a whim and as a result they might as well be one number.

Well and I don't use 0 because 0 means nothing and if there is nothing why deploy.

Anyways can we just parse the version match which works fine but use the original value not the semverfied one? Without starting a religious war maybe?

@stickycode
Copy link
Contributor Author

see #81

worth noting I created the PR without compiling anything, its seems simple enough though that I might just get away with it

@rusenask
Copy link
Collaborator

rusenask commented Aug 6, 2017

Thanks, should work. We already had similar a issue with other versions where I thought I fixed it but apparently forgot about that NewAvailable function :) If you could open it against develop branch that would be great.

@stickycode
Copy link
Contributor Author

See #82 which is to develop not master

@rusenask
Copy link
Collaborator

rusenask commented Aug 6, 2017

Tagged new patch release with the change https://github.com/rusenask/keel/releases/tag/0.4.5. Docker cloud builder should produce an image soon :) Thanks!

@stickycode
Copy link
Contributor Author

Working for me now

knechtionscoding pushed a commit to knechtionscoding/keel that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants