Build with kubernetes 1.24 #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Build with kubernetes 1.24 libraries * Try to resolve circle build error * Fix build warnings * Update test parser to use modern command install method * Attempt to pass helm chart testing * Correct testing kube version * Update go version used by the drone ci * Remove beta versions from templetes
|
dope |
|
I will get to this on Friday/Saturday, totally fine to remove helm v2, no need to keep it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #698
In Kubernetes 1.25 several of the beta apis used by Keel are removed and replaced by the stable v1 equivalents. For those of us that are using Keel as a critical part of our deployment processes and who want to use current/future versions of Kubernetes this presents a huge problem.
I've created a build using the Kubernetes 1.24 libraries, updated golang, etc.
This change is breaking because it removes Helm 2 support. Helm 2 was EOL back in 2020.
I couldn't figure out how to get the ci/circleci: install-charts check working. This check is also failing on the master branch and I would appreciate any help in getting that or a similar check working.
Please let me know if there is anything I can do to speed up getting this merged released.