Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add json support #30

Merged
merged 22 commits into from
Aug 18, 2023
Merged

feat: add json support #30

merged 22 commits into from
Aug 18, 2023

Conversation

kekavc24
Copy link
Owner

@kekavc24 kekavc24 commented Aug 15, 2023 •
edited
Loading

Description

Closes #28

This PR also makes some internal code changes that don't impact functionality. These changes include:

  • Improves folder structure. Code is better organized (subjective).
  • Decouples argument validation for each command.
  • Code testability. Private methods provided by validator mixin are now testable.

Changes made by this PR set the stage for calVer support.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@kekavc24
refactor: code clean-up
2921793 
* update code documentation
* improve code readability
@kekavc24
chore: set base version for mocktail
47cad20
@kekavc24
refactor: add core folder
93dbe63 
* store reusable code in core folder
@kekavc24
refactor: decouple code for each command
369ebd0 
> add implementation for each command
> clean up mixin code
> improve code documentation
> move `typedef`s to separate folder
@kekavc24
refactor: implement changes in 369ebd0
45a22e8 
> add code comments for clarity
@kekavc24
test: add tests for new classes
dd40577 
> remove old tests referencing decoupled functionality
> add sanitizer tests
@kekavc24
refactor: add missing with-path implementation
1d45781
@kekavc24
fix: fix bug caught in test
c93beee 
> fix mistake where prepped args used un-sanitized args
@kekavc24
test: remove check for logger call
095f4dd 
> the error returned is preceded by another non-related error
@kekavc24
feat: add json support
51a0534
@kekavc24
refactor: rename parameter
f42c815 
> rename `isModify` to `useYamlVersion`
> renaming gives context on function
@kekavc24 kekavc24 added patch release Pull request is part of a patch release tests adds/modifies/removes tests labels Aug 15, 2023
@kekavc24 kekavc24 marked this pull request as ready for review August 18, 2023 00:04
@kekavc24 kekavc24 added documentation Improvements or additions to documentation adds-feature Pull request adds new feature with pending release to production. github_actions Pull requests that update GitHub Actions code labels Aug 18, 2023
@kekavc24
fix: fix bug where empty args where used
ff11225 
> return a string if normalized arg is empty
> throw error when no args are passed
@kekavc24
refactor: code cleanup
8159d29 
> abstract the command handlers
> remove old comments
@kekavc24
docs: update README & description
f0b9c8d
@kekavc24
docs: update code documentation
41a9c59
@kekavc24
Copy link
Owner Author

Looks good! Great job! 😅👍🏼

@kekavc24 kekavc24 merged commit 32231b8 into master Aug 18, 2023
3 checks passed
@kekavc24 kekavc24 deleted the feat/add-json-support branch August 18, 2023 11:23
@kekavc24 kekavc24 mentioned this pull request Aug 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
adds-feature Pull request adds new feature with pending release to production. documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code patch release Pull request is part of a patch release tests adds/modifies/removes tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add json support
1 participant
@kekavc24