refactor: clean up code #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> add dedicated class for version modifiers > remove normalize & validate mixins > move mixin code to respective `ArgChecker` classes > remove hard coded values. Add extension on `ArgResults` for ease. > add `PresetType` enum > add `PathInfo` typedef
> move mixin tests to respective tests for each `ArgChecker` class
kekavc24
added
documentation
> fix changelog headings style
> add class for runnable commands/subcommands > code cleanup
Bumps [cli_completion](https://github.com/VeryGoodOpenSource/cli_completion) from 0.3.0 to 0.4.0. - [Release notes](https://github.com/VeryGoodOpenSource/cli_completion/releases) - [Changelog](https://github.com/VeryGoodOpenSource/cli_completion/blob/main/CHANGELOG.md) - [Commits](VeryGoodOpenSource/cli_completion@v0.3.0...v0.4.0) --- updated-dependencies: - dependency-name: cli_completion dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit acd344f)
Bumps [pub_updater](https://github.com/VeryGoodOpenSource/pub_updater) from 0.3.1 to 0.4.0. - [Release notes](https://github.com/VeryGoodOpenSource/pub_updater/releases) - [Changelog](https://github.com/VeryGoodOpenSource/pub_updater/blob/main/CHANGELOG.md) - [Commits](VeryGoodOpenSource/pub_updater@v0.3.1...v0.4.0) --- updated-dependencies: - dependency-name: pub_updater dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit cb03082)
> reduce core logic present in handler > add class for exclusively modifying/bumping `SEMVER` version > consolidate code to said class which was a bit scattered > improve general testability & maintainability to core code
> remove `keep-pre` & `keep-build` from extension method > add `presetType` to `VersionModifiers` super class
> remove core logic > remove version validation. > reuse version code added in ab77a2b
> change name to one which makes sense!
> add tests for new functionality > consolidate tests present in `version-extension` tests > remove dead code in tests
> return only `Preset.version` when `keep-build` & `keep-pre` are false > fix issue where empty build & prerelease are added > prevent overwriting of old info from version
> ignore flag absent in `Set` subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves code readability, maintainability and testability. Still steadily on course to #27.
Key target for this PR was to try decouple code as much as possible and prevent any overlapping functionality.
Type of Change