Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor code improvements in tests #5

Merged
merged 2 commits into from
May 10, 2023
Merged

chore: minor code improvements in tests #5

merged 2 commits into from
May 10, 2023

Conversation

kekavc24
Copy link
Owner

Description

  • This PR builds on changes made in ce82d15 where tests failed but were passing in vs-code
  • Improves code in tests.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@kekavc24 kekavc24 added patch release Pull request is part of a patch release tests adds/modifies/removes tests labels May 10, 2023
@kekavc24 kekavc24 merged commit e20a3d8 into master May 10, 2023
kekavc24 added a commit that referenced this pull request May 10, 2023
@kekavc24
Revert "chore: minor code improvements in tests (#5)"
4596373 
This reverts commit e20a3d8.
@kekavc24 kekavc24 deleted the chore--quality-of-life branch May 10, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch release Pull request is part of a patch release tests adds/modifies/removes tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kekavc24