fix: destroy old planets when new ones are created

kenjinp · Dec 23, 2023 · 6cc5227 · 6cc5227
1 parent bfb1da5
commit 6cc5227
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/cool-owls-kick.md b/.changeset/cool-owls-kick.md
@@ -0,0 +1,5 @@
+---
+"@hello-worlds/react": patch
+---
+
+Dispose old planets when new planets are created
diff --git a/README.md b/README.md
@@ -4,7 +4,7 @@ https://user-images.githubusercontent.com/5485824/196038523-2ff806cd-6d75-4d7e-8
 
 ## Overview
 
-**CPU-based terrain generation for three.js or react three fiber**
+**Multi-threaded, CPU-based terrain generation for three.js or react three fiber**
 
 > **Warning**
 > These libraries are a work in progress. APIs may change unexpectedly until they reach version 1.0.

diff --git a/packages/react/src/planet/Planet.tsx b/packages/react/src/planet/Planet.tsx
@@ -141,9 +141,9 @@ function PlanetInner<D>(
 
   React.useEffect(() => {
     return () => {
-      helloPlanet.dispose()
+      helloPlanet?.dispose()
     }
-  }, [])
+  }, [helloPlanet])
 
   React.useEffect(() => {
     if (helloPlanet) {