Skip to content

Commit

Permalink
iojs 2.1 compatibility: remove extra args to Signature::New().
Browse files Browse the repository at this point in the history
I don't know when these arguments became optional and then illegal,
but iojs 2.1 (V8 4.2) does not like seeing them at all, and nodejs
0.12.0 (V8 3.28) is fine without seeing them.

I didn't test nodejs 0.11.x (x >= 13) which also follow this path
and might not like it.

The module compiles, and tests pass, with nodejs 0.12.0 and iojs
2.1.0.
  • Loading branch information
Matt Ginzton authored and laverdet committed Jul 2, 2015
1 parent 9c682b1 commit 5dd5672
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/fibers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,9 @@ namespace uni {

Handle<Signature> NewSignature(
Isolate* isolate,
Handle<FunctionTemplate> receiver = Handle<FunctionTemplate>(),
int argc = 0,
Handle<FunctionTemplate> argv[] = 0
Handle<FunctionTemplate> receiver = Handle<FunctionTemplate>()
) {
return Signature::New(isolate, receiver, argc, argv);
return Signature::New(isolate, receiver);
}

void AdjustAmountOfExternalAllocatedMemory(Isolate* isolate, int64_t change_in_bytes) {
Expand Down

0 comments on commit 5dd5672

Please sign in to comment.