One Hot 2d Matrix to Make Sparse 3d Matrix #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for text processing in sequence to sequence
|
|
||
|
|
||
| def one_hot_2d_matrix(matrix2d): | ||
| maxinteger = matrix2d.max() |
There was a problem hiding this comment.
No check that matrix2d is a Numpy array...
|
I apologize for the non-checks. Let me close this PR, and if I get around to ensuring it goes through those checks, I will submit another PR! Appreciate the feedback. |
fchollet
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for text processing in sequence to sequence