-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab _always_ misinterpreted as New Container Tab … #56
Comments
mmm ... yeah: that's currently a wanted behavior. |
Thanks. And I've been quietly .oO(thinking) that this might be somehow related to loady-leaky |
@kesselborn I think you should decide what you want the goals of this extension to be. Currently it does 3 things, any combination of which could be their own extension.
To whatever extent these features do not rely on shared logic, I would strongly suggest breaking them into separate extensions, so that users can mix and match as they please. That will also minimize the conflicts with other extensions that modify the same behavior. For example, I'd love if containers on the go modified the behavior of However, this would not make sense if the end goal for this extension is still to be a replacement for tab groups (ie, eventually, hiding tabs that are not in the current container -- more like chrome profiles). |
@smichel17 great point and I don’t know why I missed that: yes: the goal is to be a tab-group replacement and only one container will be visible at a time, which is why new tabs are always in the current container. |
Thanks. Over to https://discourse.mozilla.org/t/-/15331/4?u=grahamperrin … |
@kesselborn I think quietly about this issue almost every day.
I share the wish for not too many user preferences.
On one hand: I reckon, if that behaviour can become a highly experimental preference – not a default – then large chunks of the rest of Conex can become non-experimental. That's just my tester's instinct. (No relevant knowledge of coding or APIs.) On the other hand: the current inflexibility probably does make it easier to identify bugs. ElsewhereFrom #68 (comment) (2017-10-22) under opening external links does not open url in contained tab anymore · Issue
I'm thinking about both (a) this #56 and (b) nearby #68 in the context of:
– and related Mozilla bugs:
PostscriptOf those four Mozilla bugs, 1408053 might have the greatest potential to reshape our thoughts. |
open new tabs automatically in current tabgroup · Issue #11 · kesselborn/conex
Probably as a result of that, Control-T and (on a Mac) Command-T never produce a non-contained new tab. And when New Tab is chosen in the File menu, it's as if something else was chosen.
Whilst the change of interpretation will be appreciated by some users, it should be a user preference – not always enforced by the extension.
Related, for a different extension
Option to open new Tabs in the same Container · Issue #462 · mozilla/multi-account-containers
The text was updated successfully, but these errors were encountered: