This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Issue #15 : added 2 new methods #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in issue kevinlawler#15, added two new methods that can be used as drop-in replacement to timeAgo: dateTimeAgo and dateTimeUntilNow. See header file for more details about those methods. Also refactored some code in timeAgo to simplify it.
|
How confident are you this is correct? You have commit access. You can merge if you're sure it's right. |
chrisben
added a commit
that referenced
this pull request
May 20, 2013
Issue #15 : added 2 new methods
|
Now as the previous timeAgo method hasn't changed (minus the small refactor) it shouldn't create any problem for people just upgrading. I've also just now added the new strings to translation + updated Readme. Note: the new methods might use new texts that are not yet translated in your Language -- if used for anything else than English or French, make sure you add translations first. |
|
Please see here for suggestions on how to deal with the addition of new strings: |
|
Ah, I see @chrisben is already ahead of me there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #15, added two new methods that can be used as
drop-in replacement to timeAgo: dateTimeAgo and dateTimeUntilNow. See
header file for more details about those methods.
Also refactored some code in timeAgo to simplify it.