Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to fixed width integers everywhere #125

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Switch to fixed width integers everywhere #125

merged 2 commits into from
Dec 14, 2021

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Use fixed width integer types throughout the whole datamodel.

ENDRELEASENOTES

See #112
Needs AIDASoft/podio#234

vvolkl
vvolkl approved these changes Nov 26, 2021
View reviewed changes
Copy link
Collaborator

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe you can remove the CI workflows with the old stacks that don't build their own updated podio?

@tmadlener
Copy link
Contributor Author

I kept the workflows for now, but changed the required tests to be the ones that build podio on the fly. Is there a way to keep the workflow files unchanged, but disable the actions from running?

@vvolkl vvolkl merged commit ad89a90 into key4hep:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolkl vvolkl vvolkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @vvolkl