-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version file compatible with other Key4hep packages #152
Conversation
@tmadlener Is there a way to write this version to the metadata as well? Would probably need to be done in podio or in the user code? |
For podio we are already writing the build version of podio. However, there is no "easy" way yet to do it for a generated datamodel like EDM4hep. What could be done at the moment is to write the 64 bit encoded Since writing the version is necessary in any case for schema evolution, this has to be solved in any case rather soon. With that in mind, maybe the current header has to be considered as not completely stable yet. |
ae1f668
to
220d434
Compare
Merging this as it is at the moment, and decide how to deal with the schema version once that is actually available. |
EDM4hepVersion.h.in
Outdated
// necessary | ||
|
||
/// Define a version to be used in edm4hep. | ||
#define EDM4HEP_VERSION(major, minor, patch) (((unsigned long)(major) << 32) | ((unsigned long)(minor) << 16) | ((unsigned long)(patch))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work when used in the preprocessor. See AIDASoft/podio#374
739740a
to
8cba1a5
Compare
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
b13b0d6
to
466ee0d
Compare
Meeting: Podio could generate this file (and add schema information into it) |
I think that would be a slightly bigger thing to discuss. feature creep is a big risk there... |
See key4hep/EDM4hep#152 for name change.
See key4hep/EDM4hep#152 for name change.
BEGINRELEASENOTES
EDM4hepVersion.h
file that has the same basic structure and functionality as other Key4hep packages.ENDRELEASENOTES