Make sure that operator[] return the right types #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed this was in https://github.com/key4hep/EDM4hep/pull/285/checks#step:3:1214, which I should have checked but it always fails with EDM4hep because of some package at the end of the dependency tree |
jmcarcell
approved these changes
Mar 12, 2024
|
The downstream build seems to be back to the usual failure? |
|
Yeah, maybe I should remove KalDet from these checks, but I guess it should compile fine with default options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
operator[]of theVectorNxtypes return the correct type.ENDRELEASENOTES
Follow up on #285 where we somehow missed the wrong return types in the review.