Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read test #2

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Add read test #2

merged 2 commits into from
Jul 2, 2020

Conversation

andresailer
Copy link
Contributor

This adds a test that reads the collections that are written in the write test.

@andresailer andresailer requested a review from vvolkl June 16, 2020 14:44
Copy link
Contributor

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vvolkl
Copy link
Contributor

vvolkl commented Jun 16, 2020

@andresailer The build failure is caused by the init.sh which included a workaround for Gaudi in LCG_96c_LS, which causes problems now that the nightlies switched to 97. (There is another workaround needed for Gaudi in 97, but I added this in the setup.sh on cvmfs). Could you rebase on master to get the updated init.sh?

@andresailer
Copy link
Contributor Author

@vvolkl Thanks for fixing the CI, I rebased.

@vvolkl
Copy link
Contributor

vvolkl commented Jun 17, 2020

Now the failure seems to be due to the bug previously reported, I'll take a look!

@andresailer
Copy link
Contributor Author

It probably needs the podio and edm4hep changes for the dictionaries

@vvolkl
Copy link
Contributor

vvolkl commented Jun 17, 2020

Yes, I tested this locally and it works with AIDASoft/podio#99 and key4hep/EDM4hep#68 and a LD_LIBRARY_PATH that includes the rootmap files. I'll wait unitil those PRs are merged to master, and picked up by the nightlies.

@vvolkl vvolkl merged commit d53c8ae into key4hep:master Jul 2, 2020
@andresailer andresailer deleted the addReadTest branch July 2, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants