Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the cmake ExternalData to download the test data #33

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Nov 1, 2023

BEGINRELEASENOTES

ENDRELEASENOTES
In this case this is a bit different from the podio pull request because for people that are building only but not running the tests they will be downloading the files unnecessarily. This can be solved by passing a path to keep a local cache of the files when running cmake with -DExternalData_OBJECT_STORES=/path/to/folder.

@tmadlener
Copy link
Contributor

Can you elaborate why in this case the files are downloaded unconditionally? I.e. what is different wrt the podio PR?

@jmcarcell
Copy link
Contributor Author

It's the same but for this repo the files were only downloading when running the tests so for someone who builds them but doesn't run them this actually makes it worse by having to download them, although possibly only once if using ExternalData_OBJECT_STORES

@tmadlener
Copy link
Contributor

Ah right, so the behavior of this changes slightly. I was looking for differences wrt podio.

@tmadlener tmadlener merged commit 91fafab into main Nov 2, 2023
4 of 7 checks passed
@tmadlener tmadlener deleted the tests branch November 2, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants