Skip to content

Commit

Permalink
test algs: don't override methods only tocall base method
Browse files Browse the repository at this point in the history
  • Loading branch information
m-fila committed Aug 23, 2024
1 parent 2bd0069 commit 8452b9d
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 75 deletions.
2 changes: 0 additions & 2 deletions test/k4FWCoreTest/src/components/TestUniqueIDGenSvc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,3 @@ StatusCode TestUniqueIDGenSvc::execute(const EventContext&) const {

return StatusCode::SUCCESS;
}

StatusCode TestUniqueIDGenSvc::finalize() { return Gaudi::Algorithm::finalize(); }
4 changes: 0 additions & 4 deletions test/k4FWCoreTest/src/components/TestUniqueIDGenSvc.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ class TestUniqueIDGenSvc : public Gaudi::Algorithm {
* @return status code
*/
StatusCode execute(const EventContext&) const final;
/** Finalize.
* @return status code
*/
StatusCode finalize() final;

private:
SmartIF<IUniqueIDGenSvc> m_service;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ k4FWCoreTest_CheckExampleEventData::k4FWCoreTest_CheckExampleEventData(const std
setProperty("Cardinality", 1).ignore();
}

StatusCode k4FWCoreTest_CheckExampleEventData::initialize() { return Gaudi::Algorithm::initialize(); }

StatusCode k4FWCoreTest_CheckExampleEventData::execute(const EventContext&) const {
auto floatVector = m_vectorFloatHandle.get();
if (floatVector->size() != 3 || (*floatVector)[2] != m_event) {
Expand All @@ -59,5 +57,3 @@ StatusCode k4FWCoreTest_CheckExampleEventData::execute(const EventContext&) cons
}
return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_CheckExampleEventData::finalize() { return Gaudi::Algorithm::finalize(); }
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,10 @@ class k4FWCoreTest_CheckExampleEventData : public Gaudi::Algorithm {
public:
explicit k4FWCoreTest_CheckExampleEventData(const std::string&, ISvcLocator*);
~k4FWCoreTest_CheckExampleEventData() = default;
/** Initialize.
* @return status code
*/
StatusCode initialize() final;
/** Execute.
* @return status code
*/
StatusCode execute(const EventContext&) const final;
/** Finalize.
* @return status code
*/
StatusCode finalize() final;

private:
/// integer to add to the dummy values written to the edm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,6 @@ k4FWCoreTest_CreateExampleEventData::k4FWCoreTest_CreateExampleEventData(const s
setProperty("Cardinality", 1).ignore();
}

StatusCode k4FWCoreTest_CreateExampleEventData::initialize() {
if (Gaudi::Algorithm::initialize().isFailure()) {
return StatusCode::FAILURE;
}
return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_CreateExampleEventData::execute(const EventContext&) const {
auto* floatVector = m_vectorFloatHandle.createAndPut();
floatVector->push_back(125.);
Expand Down Expand Up @@ -104,5 +97,3 @@ StatusCode k4FWCoreTest_CreateExampleEventData::execute(const EventContext&) con

return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_CreateExampleEventData::finalize() { return Gaudi::Algorithm::finalize(); }
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,10 @@ namespace edm4hep {
class k4FWCoreTest_CreateExampleEventData : public Gaudi::Algorithm {
public:
explicit k4FWCoreTest_CreateExampleEventData(const std::string&, ISvcLocator*);
/** Initialize.
* @return status code
*/
StatusCode initialize() final;
/** Execute.
* @return status code
*/
StatusCode execute(const EventContext&) const final;
/** Finalize.
* @return status code
*/
StatusCode finalize() final;

private:
/// integer to add to the dummy values written to the edm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ k4FWCoreTest_HelloWorldAlg::k4FWCoreTest_HelloWorldAlg(const std::string& aName,
setProperty("Cardinality", 1).ignore();
}

StatusCode k4FWCoreTest_HelloWorldAlg::initialize() {
if (Gaudi::Algorithm::initialize().isFailure()) {
return StatusCode::FAILURE;
}
return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_HelloWorldAlg::execute(const EventContext&) const {
info() << endmsg;
info() << endmsg;
Expand All @@ -42,5 +35,3 @@ StatusCode k4FWCoreTest_HelloWorldAlg::execute(const EventContext&) const {
info() << endmsg;
return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_HelloWorldAlg::finalize() { return Gaudi::Algorithm::finalize(); }
8 changes: 0 additions & 8 deletions test/k4FWCoreTest/src/components/k4FWCoreTest_HelloWorldAlg.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,10 @@
class k4FWCoreTest_HelloWorldAlg : public Gaudi::Algorithm {
public:
explicit k4FWCoreTest_HelloWorldAlg(const std::string&, ISvcLocator*);
/** Initialize.
* @return status code
*/
StatusCode initialize() final;
/** Execute.
* @return status code
*/
StatusCode execute(const EventContext&) const final;
/** Finalize.
* @return status code
*/
StatusCode finalize() final;

private:
// member variable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ k4FWCoreTest_cellID_reader::k4FWCoreTest_cellID_reader(const std::string& aName,
setProperty("Cardinality", 1).ignore();
}

StatusCode k4FWCoreTest_cellID_reader::initialize() {
if (Gaudi::Algorithm::initialize().isFailure()) {
return StatusCode::FAILURE;
}
return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_cellID_reader::execute(const EventContext&) const {
const auto simtrackerhits_coll = m_simTrackerHitReaderHandle.get();

Expand All @@ -48,5 +41,3 @@ StatusCode k4FWCoreTest_cellID_reader::execute(const EventContext&) const {

return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_cellID_reader::finalize() { return Gaudi::Algorithm::finalize(); }
8 changes: 0 additions & 8 deletions test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,10 @@
class k4FWCoreTest_cellID_reader : public Gaudi::Algorithm {
public:
explicit k4FWCoreTest_cellID_reader(const std::string&, ISvcLocator*);
/** Initialize.
* @return status code
*/
StatusCode initialize() final;
/** Execute.
* @return status code
*/
StatusCode execute(const EventContext&) const final;
/** Finalize.
* @return status code
*/
StatusCode finalize() final;

private:
/// Handle for the SimTrackerHits to be read
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,3 @@ StatusCode k4FWCoreTest_cellID_writer::execute(const EventContext&) const {

return StatusCode::SUCCESS;
}

StatusCode k4FWCoreTest_cellID_writer::finalize() { return Gaudi::Algorithm::finalize(); }
4 changes: 0 additions & 4 deletions test/k4FWCoreTest/src/components/k4FWCoreTest_cellID_writer.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ class k4FWCoreTest_cellID_writer : public Gaudi::Algorithm {
* @return status code
*/
StatusCode execute(const EventContext&) const final;
/** Finalize.
* @return status code
*/
StatusCode finalize() final;

private:
/// Handle for the SimTrackerHits to be written
Expand Down

0 comments on commit 8452b9d

Please sign in to comment.