Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessing metadata with MetaDataHandle when MetadataSvc is present #231

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Fix accessing metadata with MetaDataHandle when MetadataSvc is present #231

merged 6 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. check metadata access with optional in the tests

    @m-fila
    m-fila committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c990028 View commit details
    Browse the repository at this point in the history

  2. don't create metadatasvc when checking if it exists

    @m-fila
    m-fila committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    eeaac4c View commit details
    Browse the repository at this point in the history

  3. check if PodioDataSvc exists in get_optional

    @m-fila
    m-fila committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b03288d View commit details
    Browse the repository at this point in the history

  4. fix unchecked optional for MetaDataHandle using IOSvc

    @m-fila
    m-fila committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f575a37 View commit details
    Browse the repository at this point in the history

  5. remove unused declared but not defined constructor

    @m-fila
    m-fila committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7e10b2f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Apply suggestions from code review

    @jmcarcell
    jmcarcell authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0c36f30 View commit details
    Browse the repository at this point in the history