Tack track curvature directly from Delphes and don't recompute it from pT #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s omega directly from the curvature of the delphes track, instead of recomputing it from its pT.
tmadlener
reviewed
Oct 9, 2023
tmadlener
reviewed
Oct 30, 2023
25 tasks
|
CI based on nightlies seems to be broken currently due to key4hep/key4hep-spack#540. However, since things build on top of the current release I will still merge this in order to make a new tag. |
tmadlener
approved these changes
Nov 2, 2023
tmadlener
changed the title
|
@EmanuelPerez thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
An example is shown in the attached plots. They show the pull of the reconstructed position of a displaced vertex in some B physics process, running the very same code over the same events, the only difference being the definition of the track's omega in DelphesEDM4HepConverter::convertTrack. With the current code, the pull shows some non gaussian tails, which are absent if omega is taken directly from the curvature of Delphes.