fix(developer): publish @keymanapp/keyman-version to npm
#7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7582. Because of npm/cli#3466, we must publish our internal dependency @keymanapp/keyman-version. This change adds a common builder function builder_publish_to_npm in build-utils-ci.inc.sh to help with that task, which should be adopted by other scripts that need to publish to npm, in the future. For now, responsibility for publishing keyman-version is delegated to kmlmc. In the future, we will move this to a single top-level build action that publishes all npm modules across the entire repo for the given version.
mcdurdin
requested review from
jahorton,
darcywong00 and
sgschantz
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
8 tasks
github-actions
bot
added
common/
common/resources/
jahorton
approved these changes
Nov 2, 2022
|
Changes in this pull request will be available for download in Keyman version 16.0.95-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7582.
Because of npm/cli#3466, we must publish our internal dependency
@keymanapp/keyman-version. This change adds a common builder function builder_publish_to_npm in build-utils-ci.inc.sh to help with that task, which should be adopted by other scripts that need to publish to npm, in the future.For now, responsibility for publishing keyman-version is delegated to kmlmc. In the future, we will move this to a single top-level build action that publishes all npm modules across the entire repo for the given version.
We will need to verify whether this is working correctl when we publish the next beta release post-merge. The change will percolate down to alpha with our normal beta-to-alpha merge process.
@keymanapp-test-bot skip