Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated hooks #9204

Open
wants to merge 61 commits into
base: v-next
Choose a base branch
from

Conversation

gautamsi
Copy link
Member

@gautamsi gautamsi commented Jul 8, 2024

This replaces all the hooks from original combined form with the granular one inline with #9056 #9057 #8826

this cleans up the code and is breaking changes.

Copy link

codesandbox-ci bot commented Jul 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a54a00:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens
Copy link
Member

dcousens commented Jul 8, 2024

I'll be merging #9166 ASAP, which should help with this pull request, fwiw

@gautamsi
Copy link
Member Author

gautamsi commented Jul 8, 2024

If we go the way of this PR, #9166 would not be needed I think.

This should be part of v-next branch so that it can take longer, you should merge #9166

@gautamsi gautamsi changed the base branch from main to v-next July 8, 2024 05:10
@gautamsi gautamsi force-pushed the operation-fields-hooks branch 2 times, most recently from 73b2403 to e2f6ad3 Compare July 18, 2024 01:55
@gautamsi gautamsi marked this pull request as ready for review July 18, 2024 02:11
@gautamsi gautamsi changed the title [WIP] Remove deprecated hooks Remove deprecated hooks Jul 18, 2024
@gautamsi gautamsi changed the base branch from v-next to main July 18, 2024 14:53
@gautamsi gautamsi changed the base branch from main to v-next July 18, 2024 14:53
renovate bot and others added 5 commits July 23, 2024 10:46
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
…G and Twitter images (keystonejs#9228)

Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@gautamsi
Copy link
Member Author

@dcousens I am done with this, are you able to take a look and help resolve single type error in lint and documentation.

@gautamsi
Copy link
Member Author

I have created documentation in separate PR #9231

@gautamsi gautamsi mentioned this pull request Jul 29, 2024
15 tasks
renovate bot and others added 5 commits July 30, 2024 09:15
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
dcousens and others added 16 commits August 14, 2024 09:50
Co-authored-by: Andrei Luca <1881266+iamandrewluca@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot and others added 12 commits August 28, 2024 08:59
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants