Save work to repro fuzzer failure.

kgpai · Sep 10, 2024 · 7a923c6 · 7a923c6
1 parent cc10dc2
commit 7a923c6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/velox/expression/fuzzer/ExpressionFuzzer.cpp b/velox/expression/fuzzer/ExpressionFuzzer.cpp
@@ -313,8 +313,9 @@ static void filterSignatures(
     for (auto it = input.begin(); it != input.end();) {
       if (!nameSet.count(it->first)) {
         it = input.erase(it);
-      } else
+      } else {
         it++;
+      }
     }
   }
 

diff --git a/velox/expression/fuzzer/ExpressionFuzzerVerifier.cpp b/velox/expression/fuzzer/ExpressionFuzzerVerifier.cpp
@@ -342,7 +342,16 @@ void ExpressionFuzzerVerifier::go() {
           resultVectors ? BaseVector::copy(*resultVectors) : nullptr,
           true, // canThrow
           columnsToWrapInLazy);
-    } catch (const std::exception&) {
+    } catch (const std::exception& exp) {
+      auto veloxError = dynamic_cast<const VeloxRuntimeError*>(&exp);
+      if (veloxError &&
+          veloxError->message() ==
+              "Unicode characters are not supported for conversion to integer types") {
+        LOG(WARNING)
+            << "Ignoring conversion of unicode characters to integer types error";
+        continue;
+      }
+
       if (options_.findMinimalSubexpression) {
         test::computeMinimumSubExpression(
             {&execCtx_, {false, ""}},