Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Update takes two Runs to fully update a modified Diagram #48

Closed
a-sr opened this issue Jul 1, 2020 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@a-sr
Copy link
Member

a-sr commented Jul 1, 2020

If a diagram is modified on-the-fly in the view (e.g. nodes are removed by an action) the incremental update requires two runs until changes in the model (new synthesis run) are correctly applied to the diagram. The first result is always broken.

Example

  1. Fresh diagram.
    cycle_filter1
  2. The user pressed "Filter Cycle" to remove all nodes that are not highlighted. Changes were made by an action (no synthesis run).
    cycle_filter2
  3. The user fixed the problem and saved the model. A new synthesis was invoked but the result is broken.
    cycle_filter3
  4. Only after another update (synthesis re-run) the resulting diagram is correctly displayed.
    cycle_filter4
@a-sr a-sr added the bug Something isn't working label Jul 1, 2020
NiklasRentzCAU added a commit that referenced this issue Jul 14, 2020
order as they appear in the new graph. Fixes Issue #48.
@NiklasRentzCAU
Copy link
Member

Fixed in d21bf90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants