Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ide independent stuff into an ide plugin #41

Merged
merged 5 commits into from
Jun 10, 2020

Conversation

soerendomroes
Copy link
Member

No description provided.

@soerendomroes soerendomroes marked this pull request as ready for review June 8, 2020 14:22
@sailingKieler
Copy link
Member

The new plugin's stuff is only consumed by the ...ui.view plugin, right?
Is it intended to be used in non-Eclipse-based IDEs? Might make sense to add an derived version of https://github.com/kieler/KLighD/blob/master/plugins/de.cau.cs.kieler.klighd.standalone/src/de/cau/cs/kieler/klighd/standalone/KlighdStandaloneSetup.java, doesn't it?

@soerendomroes
Copy link
Member Author

The main idea was to make the syntheses and stuff like the MessageModel available for setups that do not want to consume the ui plugins. I think a StandaloneSetup is orthogonal to this issue.
I suggest to add one if the need arises or is there already one @NiklasRentzCAU ?
This refactoring is a first step to do the same for the KIELER semantics bundles.

Copy link
Member

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the additions & moves.

@NiklasRentzCAU
Copy link
Member

Also looks good to me.
There is no derived version of the standalone setup yet, I don't see that we need one anyway. The language server setup in the keith branch will need that, but is not fully implemented over there yet. If we see something that needs to be added to the ide plugin, we'll do it then.

@NiklasRentzCAU
Copy link
Member

Please have a look at the failed PR-build over here first, though.
Can't we add a way to include the build status of these PR builds on GitHub? I think I saw something like that over at other repositories already.

@soerendomroes
Copy link
Member Author

The PR build seems to be successful now.

@uruuru
Copy link
Member

uruuru commented Jun 10, 2020

@NiklasRentzCAU I guess you refer to github actions. Have a look at this config, should only require small adjustemts: https://github.com/eclipse/elk/blob/master/.github/workflows/ci.yml

@soerendomroes soerendomroes merged commit 53f94f6 into master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants