Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klighd +.piccolo: enabled support of multiple KTexts per KLabel as demanded in #43 #55

Merged
merged 1 commit into from
Aug 3, 2020
Merged

klighd +.piccolo: enabled support of multiple KTexts per KLabel as demanded in #43 #55

merged 1 commit into from
Aug 3, 2020

Conversation

sailingKieler
Copy link
Member

  • introduced guarding property 'MULTIPLE_KTEXTS_PER_KLABEL' preserving the existing behavior by default if not explicitly set to 'true'
  • relaxed handling of label text, may now be specified within the first KText alternatively
  • dropped dead code as discussed in Drop dead code #54

@sailingKieler
klighd +.piccolo: enabled support of multiple KTexts per KLabel as de…
c8b7246 
…manded in #43

* introduced guarding property 'MULTIPLE_KTEXTS_PER_KLABEL' preserving the existing behavior by default if not explicitly set to 'true'
* relaxed handling of label text, may now be specified within the first KText alternatively
* dropped dead code as discussed in #54
NiklasRentzCAU
NiklasRentzCAU approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this does not force anything for existing behavior, this looks good to keep the old behavior. I don't see yet how this would work with a synthesis activating the new property in terms of the size estimation etc. as I don't have an example for that. As that does not affect us directly though, this looks to be good.

@le-cds
Copy link
Member

le-cds commented Jul 17, 2020

I guess you should at least open an issue to track investigating size estimations.

@sailingKieler sailingKieler merged commit 4a06b9c into master Aug 3, 2020
@sailingKieler sailingKieler deleted the cs-43and54labels branch October 26, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasRentzCAU NiklasRentzCAU NiklasRentzCAU approved these changes

@le-cds le-cds Awaiting requested review from le-cds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sailingKieler @le-cds @NiklasRentzCAU