Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klighd.lsp: Added main thread queue for SWT and AWT calls. #66

Merged
merged 3 commits into from
Aug 20, 2020
Merged

klighd.lsp: Added main thread queue for SWT and AWT calls. #66

merged 3 commits into from
Aug 20, 2020

Conversation

soerendomroes
Copy link
Member

No description provided.

NiklasRentzCAU
NiklasRentzCAU reviewed Aug 20, 2020
View reviewed changes
Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just why are all the return null statements necessary in the functions and the calls? Those seem a little odd to me.

@soerendomroes
Use Consumer instead of Function.
4beb7bf 
Merge remote-tracking branch 'origin/keith' into mainThreadQueue

Conflicts:
	plugins/de.cau.cs.kieler.klighd.lsp/src/de/cau/cs/kieler/klighd/lsp/KGraphLanguageServerExtension.xtend
@soerendomroes
Copy link
Member Author

You are correct, I reworked that part.

@soerendomroes soerendomroes merged commit 7596d70 into keith Aug 20, 2020
@soerendomroes soerendomroes deleted the mainThreadQueue branch August 20, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasRentzCAU NiklasRentzCAU NiklasRentzCAU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soerendomroes @NiklasRentzCAU