Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uuid option to sipcreator #313

Closed
raecasey opened this issue Dec 5, 2018 · 11 comments
Closed

add uuid option to sipcreator #313

raecasey opened this issue Dec 5, 2018 · 11 comments

Comments

@raecasey
Copy link
Contributor

raecasey commented Dec 5, 2018

ad an arg parse -uuid that allows the user choose to rename the object and related files to a uuid.

@kieranjol
Copy link
Owner

+1, this should be added ASAP.
Off the top of my head, there already is a uuid option that allows you To specify a uuid for the package rather than getting an auto generated one. So a different argparse name is needed, like rename_uuid or something. Any ideas?

@kieranjol
Copy link
Owner

This PR has the updates - testing would be ideal in order to ensure that this update is what was required: #314

@raecasey
Copy link
Contributor Author

thanks for this - i'll test it out in the next two days and let you know

R

@raecasey
Copy link
Contributor Author

Hi - so I tested this out. am i right in saying that the -rename_uuid argument isn't on the master branch yet?
I got this return on the terminal:
usage: sipcreator.py [-h] -i I [I ...] -o O [-m M] [-u U] [-user USER] [-d]
[-quiet] [-move] [-sc] [-zip] [-oe OE]
[-supplement SUPPLEMENT [SUPPLEMENT ...]]
sipcreator.py: error: unrecognized arguments: -rename_uuid

Do I need to get into a different branch to test it out?

cheers
R

@kieranjol
Copy link
Owner

Indeed,you must
git checkout rename-uuid

@raecasey
Copy link
Contributor Author

thanks, - jeez, that was a fast reply.
i typed in
git checkout rename-uuid
git checkout rename_uuid
git checkout rename uuid
but i get this return:
fatal: Not a git repository (or any of the parent directories): .git

i am missing some step. Sorry, - I know you've shown me this loads of times
R

@kieranjol
Copy link
Owner

kieranjol commented Dec 18, 2018 via email

@kieranjol
Copy link
Owner

Also, GitHub is saying that the pull request can't be merged. There have been alterations to sipcreator since this branch was created so while it's good that you test this out so that it's as requested, the code will have to change prior to merging.

@raecasey
Copy link
Contributor Author

just tested that out there now, - worked beautifully! thank you
sipcreator_rename

@kieranjol
Copy link
Owner

Beautiful! Thanks for posting the pic.

@kieranjol
Copy link
Owner

Hi Raelene,

I resolved the conflict that was preventing the merging. It would be ideal if you could test this out one more time to ensure that the resolved conflict is still creating the desired output.

-K

kieranjol added a commit that referenced this issue Dec 25, 2018
sipcreator - adds rename_uuid option, fixes #313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants