Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print statement outside loop #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print statement outside loop #306

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2018

Small fix to finally put print statement outside main loop! Also, I have been using desktop version of this script for quite a while now as there's something up with the ifiscripts version being pulled down. Going to finally sort this out too.

Small fix to finally put print statement outside main loop! Also, I have been using desktop version of this script for quite a while now as there's something up with the ifiscripts version being pulled down. Going to finally sort this out too.
@kieranjol
Copy link
Owner

Hey, thanks for this. If there's a issue with updating the as11fixity file via update.py, then it's because the version of as11fixity.py within ifigit/ifiscripts has been edited at some point since the last git pull.

Also it looks like you're working from a very old version of as11fixity, as I rewrote it to be more PEP-08 compliant a while back.
#224

I think the functionality was identical, it was just the style that was made more in line with ifiscripts.

Which ingest station was having the issue?

@ghost
Copy link
Author

ghost commented Oct 10, 2018

Both of them I think but different issues I think. This is a old issue that I really should have gotten around to before. If I delete the as11fixity.py file from both ifigit folders and then do a new git pull, should this fix the issue?

@kieranjol
Copy link
Owner

Yes, that'll fix it, then you can see if there's still an issue with that print statement outside the loop and you can send an updated Pull Request. Cheers Eoin.

@kieranjol
Copy link
Owner

Hey, checking in on this and if this PR is still relevant after sorting out the outdated script issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant