Normalise.py changes for MACE use #333
Conversation
To be tested
Updated code to working version following 2to3 update, and edits to lines 123 and 83. This code works perfectly on home Mac, needs further testing on MACE macs.
|
Hang on, had a fail at the end on my MacPro with this code although it works fine on laptop... reviewing |
|
Managed to get it working okay on Mac Pro at office, and everything going through fine, except it's not carrying the name of the original file across to the files generated, instead it's like a 24 character alpha-numeric jumble. More work needed for MacPro v3.7.3, but working fine on MacBook v3.7.2 of Python. |
|
Thank you,I'll hopefully be able to test ASAP.. ififuncs is a bit of a
beast to transition from 2 to 3 as almost every script uses it and there's
so much potential for errors to creep in due to not having an automated
test suite.
Thanks again!
|
|
Hi Joanna, the actual 2to3 stuff looks great and I think that the bump up to 24 slices is a good idea. Maybe I/someone could add an argparse argument to specify the slice count maybe? Also is there any chance that you were using an older version of normalise.py? I see a bunch of deletions in the diff towards the end of your Pull Request, which make me think that you didn't use the latest version in the master branch? |
|
Hi Kieran, It's very possible I thought I'd downloaded the latest version when it was an original. So sorry! Can you send a link to where I download from when you get time? Just so I can be sure. Thanks :) |
|
Heyyy, the download link on the main GitHub page should do the trick...
|
|
Well I'm pretty sure that's where I downloaded it from, twice. I'll try again and compare the code to the Master branch to be sure :) |
|
Cheers joanna
|
|
Hey, well I've managed to resolve the issue on MACE's Mac. Despite replicating the alterations on MACE MacPro, the only way to fix it was to copy the working normalise/ififuncs across from my laptop to the MACE Mac... I'm checking the codes against one another and they look identical at a swift glance!! Should I do anything to check this working normalise.py version (slices 24) against your script or do you just want to burnnnn this wasted PR! |
|
Today I discovered I can close things, so shutting this one down and considering it a success. Thanks for help! |
Ran a 2to3 pass and tested here at MACE. Working great! Added missing parenthesis at line 123, and amendment to slices - now 24. Not sure if you'll want to replace your own with this, so should I change slices back to 16?
Woohoo. Made an IFIscripts pull request though :) thanks for suggesting Kieran.