-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: configure repository #1
Conversation
- add yarn.lock - add hoisted dependencies - extract tsconfig-base.json to tsconfig.json - update .gitignore
47f24fb
to
6cef926
Compare
096380b
to
c059637
Compare
node-version: 16.x | ||
cache: yarn | ||
- run: yarn install --immutable | ||
- run: yarn build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I belive this step is not required as test workflow run it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ueokande
The src/__tests__/main.test.ts
does E2E test using built js files in lib
.
Besides, jest does not do type check, the build step also serves as a type check.
os: [ubuntu-latest, windows-latest] | ||
|
||
steps: | ||
- run: git config --global core.autocrlf false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why git config is required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ueokande
This is for the test case which compares a generated CSV and a fixture.
If autocrlf
is enabled, The linebreak of fixture CSV is converted to CRLF
and mismatches to generated CSV (LF
).
Is it better to add .gitattribute?
FYI: the data-loader always exports JSON/CSV withLF
currently.
Why
We split the data-loader from kintone/js-sdk to this repo.
However, some required configurations are missing.
What
Test