chore: configure repository #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add yarn.lock - add hoisted dependencies - extract tsconfig-base.json to tsconfig.json - update .gitignore
tasshi-me
force-pushed
the
chore/configure-repository
branch
2 times, most recently
from
47f24fb
to
6cef926
Compare
tasshi-me
force-pushed
the
chore/configure-repository
branch
2 times, most recently
from
096380b
to
c059637
Compare
ueokande
reviewed
Jul 5, 2022
| node-version: 16.x | ||
| cache: yarn | ||
| - run: yarn install --immutable | ||
| - run: yarn build |
There was a problem hiding this comment.
I belive this step is not required as test workflow run it.
There was a problem hiding this comment.
@ueokande
The src/__tests__/main.test.ts does E2E test using built js files in lib.
Besides, jest does not do type check, the build step also serves as a type check.
| os: [ubuntu-latest, windows-latest] | ||
|
|
||
| steps: | ||
| - run: git config --global core.autocrlf false |
There was a problem hiding this comment.
@ueokande
This is for the test case which compares a generated CSV and a fixture.
If autocrlf is enabled, The linebreak of fixture CSV is converted to CRLF and mismatches to generated CSV (LF).
Is it better to add .gitattribute?
FYI: the data-loader always exports JSON/CSV withLF currently.
ueokande
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We split the data-loader from kintone/js-sdk to this repo.
However, some required configurations are missing.
What
Test