Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce type imports as lint rule #157

Merged
merged 2 commits into from
Nov 14, 2022
Merged

chore: enforce type imports as lint rule #157

merged 2 commits into from
Nov 14, 2022

Conversation

hung-cybo
Copy link
Contributor

@hung-cybo hung-cybo commented Nov 11, 2022 •
edited
Loading

Why

Fixes #119

What

How to test

yarn build
yarn test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@hung-cybo hung-cybo requested review from a team and tasshi-me and removed request for a team November 11, 2022 06:35
@hung-cybo hung-cybo added the good first issue Good for newcomers label Nov 14, 2022
tasshi-me
tasshi-me approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit 9510c9a into main Nov 14, 2022
@tasshi-me tasshi-me deleted the chore/119-enfoce-type-imports-as-lint-rule branch November 14, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enfoce type imports as Lint rule
2 participants
@hung-cybo @tasshi-me