-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve memory usage of record export #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueokande
suggested changes
Apr 26, 2023
src/record/export/repositories/localRecordRepositoryFromStream.ts
Outdated
Show resolved
Hide resolved
src/record/export/repositories/stringifiers/csvStringifier/index.ts
Outdated
Show resolved
Hide resolved
hung-cybo
reviewed
Apr 26, 2023
ed424cb
to
1766365
Compare
23e2dac
to
0a03e11
Compare
tasshi-me
commented
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ueokande @hung-cybo
I updated the PR reflecting your reviews!
- fix bug of
CsvStrinfigier
- update
CliKintoneError
and remove redundant implementation oftoString()
- make some fields of Repository private
- apply no-unused-imports and remove unused imports
hung-cybo
reviewed
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small comments.
src/record/export/usecases/get/__tests__/fixtures/can_download_files.ts
Outdated
Show resolved
Hide resolved
src/record/export/usecases/get/__tests__/fixtures/can_download_files_in_subtable.ts
Outdated
Show resolved
Hide resolved
src/record/export/usecases/get/__tests__/fixtures/can_get_records.ts
Outdated
Show resolved
Hide resolved
05d323d
to
a181095
Compare
ueokande
approved these changes
May 10, 2023
This was referenced Jan 17, 2024
This was referenced Jan 31, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#102
What
The basic design is the same as #218 .
How to test
Checklist
yarn lint
andyarn test
on the root directory.