Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release PR title #866

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Sep 18, 2024

Why

現在のリリースPRではconventional commitのscopeの部分にブランチ名が設定されており、これは意図したものではない。
リリースPRのタイトルをより分かりやすいフォーマットに変更した。

  • 変更前: chore(main): release 1.11.0
  • 変更後: chore: release 1.11.0 from main

NOTE: googleapis/release-please#1626 が修正されて、 ${component} をPRタイトルに利用できるようになった。
=> $componentが空になるので今回は利用しない

What

  • リリースPRのタイトルを変更

How to test

N/A

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@tasshi-me tasshi-me merged commit ca95b79 into main Sep 25, 2024
12 checks passed
@tasshi-me tasshi-me deleted the chore/update-release-pr-title-pattern branch September 25, 2024 08:15
tasshi-me added a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants