Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

--kubeconfig-flag does not work for "component apply" since 8fa88dae #1094

Closed
invidian opened this issue Oct 19, 2020 · 4 comments
Closed

--kubeconfig-flag does not work for "component apply" since 8fa88dae #1094

invidian opened this issue Oct 19, 2020 · 4 comments
Assignees
@invidian
Labels
bug Something isn't working
Milestone
v0.5.0

Comments

@invidian
Copy link
Member

Surprisingly, it works for "component delete"...
@invidian invidian added the bug Something isn't working label Oct 19, 2020
@invidian invidian self-assigned this Oct 19, 2020
@knrt10
Copy link
Member

knrt10 commented Oct 19, 2020

Should we add this in 0.5.0?

@invidian
Copy link
Member Author

Should we add this in 0.5.0?

@iaguis ?

invidian added a commit that referenced this issue Oct 19, 2020
@invidian
cli/cmd: remove getKubeconfig() dependency on viper
9344de1 
Pass explicity kubeconfig path via options instead.

Also fixes #1094.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian
Copy link
Member Author

#1018 will fix it, perhaps it could be isolated from this PR, but it is easier to fix this way.

@iaguis
Copy link
Contributor

iaguis commented Oct 19, 2020

Should we add this in 0.5.0?

Yes.

@knrt10 knrt10 added this to the v0.5.0 milestone Oct 19, 2020
invidian added a commit that referenced this issue Oct 19, 2020
@invidian
cli/cmd: remove getKubeconfig() dependency on viper
e9fa3d5 
Pass explicity kubeconfig path via options instead.

Also fixes #1094.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian added a commit that referenced this issue Oct 21, 2020
@invidian
cli/cmd: remove getKubeconfig() dependency on viper
2b4b98a 
Pass explicity kubeconfig path via options instead.

Also fixes #1094.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
knrt10 pushed a commit that referenced this issue Oct 22, 2020
@invidian @knrt10
cli/cmd: remove getKubeconfig() dependency on viper
a4ddc0e 
Pass explicity kubeconfig path via options instead.

Also fixes #1094.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
knrt10 pushed a commit that referenced this issue Oct 22, 2020
@invidian @knrt10
cli/cmd: remove getKubeconfig() dependency on viper
8724400 
Pass explicity kubeconfig path via options instead.

Also fixes #1094.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
knrt10 pushed a commit that referenced this issue Oct 22, 2020
@invidian @knrt10
cli/cmd: remove getKubeconfig() dependency on viper
3455bd0 
Pass explicity kubeconfig path via options instead.

Also fixes #1094.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@knrt10 knrt10 closed this as completed in 2c86b58 Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@invidian invidian

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
3 participants
@iaguis @invidian @knrt10