Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

remove usage of template_file #1046

Merged
merged 4 commits into from
Oct 8, 2020
Merged

remove usage of template_file #1046

merged 4 commits into from
Oct 8, 2020

Conversation

knrt10
Copy link
Member

@knrt10 knrt10 commented Oct 6, 2020

template_file is deprecated

closes: #196
Signed-off-by: knrt10 kautilya@kinvolk.io

@knrt10 knrt10 changed the title packet: use templatefile instead of template_file use templatefile instead of template_file Oct 6, 2020
template_file is deprecated.

closes: #196
Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch from 09e3689 to 97095b9 Compare October 6, 2020 09:58
@knrt10 knrt10 changed the title use templatefile instead of template_file remove usage of template_file Oct 6, 2020
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch 2 times, most recently from 712390e to b7f7e81 Compare October 6, 2020 11:00
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch 4 times, most recently from 0e1da43 to 34eb7d1 Compare October 6, 2020 11:44
template_file is deprecated.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch 2 times, most recently from d9d3db1 to 42e6d53 Compare October 6, 2020 12:31
template_file is deprecated.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch from 42e6d53 to fee90a5 Compare October 6, 2020 13:30
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch from fee90a5 to c647a53 Compare October 6, 2020 14:16
@knrt10 knrt10 marked this pull request as ready for review October 6, 2020 14:44
@knrt10 knrt10 requested a review from surajssd October 6, 2020 14:47
invidian
invidian previously approved these changes Oct 6, 2020
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

invidian
invidian previously approved these changes Oct 7, 2020
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch 3 times, most recently from e836312 to 3417837 Compare October 7, 2020 12:35
template_file is deprecated.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/remove-template_file branch from 3417837 to 607f97b Compare October 7, 2020 12:36
Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knrt10 knrt10 merged commit ba45907 into master Oct 8, 2020
@knrt10 knrt10 deleted the knrt10/remove-template_file branch October 8, 2020 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use templatefile function when possible rather than template_file resource
3 participants