This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
changed the title
packet: use templatefile instead of template_file
use templatefile instead of template_file
Oct 6, 2020
invidian
suggested changes
Oct 6, 2020
assets/terraform-modules/packet/flatcar-linux/kubernetes/controllers.tf
Outdated
Show resolved
Hide resolved
template_file is deprecated. closes: #196 Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/remove-template_file
branch
from
October 6, 2020 09:58
09e3689
to
97095b9
Compare
knrt10
changed the title
use templatefile instead of template_file
remove usage of template_file
Oct 6, 2020
knrt10
force-pushed
the
knrt10/remove-template_file
branch
2 times, most recently
from
October 6, 2020 11:00
712390e
to
b7f7e81
Compare
invidian
suggested changes
Oct 6, 2020
assets/terraform-modules/kvm-libvirt/flatcar-linux/kubernetes/bootkube.tf
Outdated
Show resolved
Hide resolved
assets/terraform-modules/kvm-libvirt/flatcar-linux/kubernetes/bootkube.tf
Outdated
Show resolved
Hide resolved
assets/terraform-modules/google-cloud/flatcar-linux/kubernetes/controllers.tf
Outdated
Show resolved
Hide resolved
knrt10
force-pushed
the
knrt10/remove-template_file
branch
4 times, most recently
from
October 6, 2020 11:44
0e1da43
to
34eb7d1
Compare
template_file is deprecated. Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/remove-template_file
branch
2 times, most recently
from
October 6, 2020 12:31
d9d3db1
to
42e6d53
Compare
template_file is deprecated. Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/remove-template_file
branch
from
October 6, 2020 13:30
42e6d53
to
fee90a5
Compare
invidian
suggested changes
Oct 6, 2020
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/profiles.tf
Outdated
Show resolved
Hide resolved
knrt10
force-pushed
the
knrt10/remove-template_file
branch
from
October 6, 2020 14:16
fee90a5
to
c647a53
Compare
invidian
previously approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
knrt10
force-pushed
the
knrt10/remove-template_file
branch
from
October 7, 2020 10:44
c647a53
to
e28d934
Compare
invidian
previously approved these changes
Oct 7, 2020
knrt10
force-pushed
the
knrt10/remove-template_file
branch
3 times, most recently
from
October 7, 2020 12:35
e836312
to
3417837
Compare
template_file is deprecated. Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/remove-template_file
branch
from
October 7, 2020 12:36
3417837
to
607f97b
Compare
invidian
approved these changes
Oct 7, 2020
surajssd
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
template_file is deprecated
closes: #196
Signed-off-by: knrt10 kautilya@kinvolk.io