Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

gangway: add a serviceaccount #1104

Merged
merged 2 commits into from
Oct 21, 2020
Merged

gangway: add a serviceaccount #1104

merged 2 commits into from
Oct 21, 2020

Conversation

iaguis
Copy link
Contributor

@iaguis iaguis commented Oct 20, 2020

Gangway relies on a service account (any service account) to be mounted
on the pod file system to figure out the cluster CA.

We've disabled automounting of the default service account with the
our admission wehbook and this was breaking Gangway.

This creates a dummy service account so the Gangway pod has access to
the cluster CA file.

Fixes #1103

TODO:

  • Test

Gangway relies on a service account (any service account) to be mounted
on the pod file system to figure out the cluster CA.

We've disabled automounting of the default service account with the
our admission wehbook and this was breaking Gangway.

This creates a dummy service account so the Gangway pod has access to
the cluster CA file.
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add deploy.Spec.Template.Spec.ServiceAccountName as a constant. But no need to change. +1. We need this merged ASAP as headlamp PR depends on it.

@invidian invidian merged commit f767846 into master Oct 21, 2020
@invidian invidian deleted the iaguis/fix-gangway branch October 21, 2020 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gangway gives an empty CA when outputting kubeconfig
3 participants