This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Update velero to 1.5.2 #1131
Merged
Update velero to 1.5.2 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
force-pushed
the
imran/update-velero-to-1.5.2
branch
from
03d8d2e
to
cdae775
Compare
surajssd
reviewed
Oct 29, 2020
surajssd
reviewed
Oct 29, 2020
knrt10
reviewed
Oct 29, 2020
assets/terraform-modules/aws/flatcar-linux/kubernetes/versions.tf
Outdated
Show resolved
Hide resolved
ipochi
force-pushed
the
imran/update-velero-to-1.5.2
branch
from
cdae775
to
0249b8e
Compare
invidian
reviewed
Oct 29, 2020
pkg/components/velero/component.go
Outdated
| if len(providers) == 0 { | ||
| return nil, fmt.Errorf("no providers configured") | ||
| if len(providers) != 1 { | ||
| return nil, fmt.Errorf("cannot have more than one provider configured, got: %d", len(providers)) |
There was a problem hiding this comment.
"cannot have more than one provider configured, got: 0" doesn't make sense.
There was a problem hiding this comment.
@invidian I have removed one conditional statement and revised the error message. If you think having two conditionals make sense for a better error message then I have no problems.
ipochi
force-pushed
the
imran/update-velero-to-1.5.2
branch
from
0249b8e
to
f0f5d9b
Compare
invidian
reviewed
Nov 2, 2020
Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/update-velero-to-1.5.2
branch
from
f0f5d9b
to
bf9658d
Compare
invidian
approved these changes
Nov 2, 2020
knrt10
approved these changes
Nov 2, 2020
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: Since this PR also updates the CRD, they need to be manually updated first.
Step before updating the component: