-
Notifications
You must be signed in to change notification settings - Fork 49
Remove Deprecated CoreOS from AWS terraform #1245
Conversation
@kskewes thanks for the PR, would you mind rebasing the PR from the master, that might fix the CI test which was fixed by #1242 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we close #1202, must also resolve warnings in aws/flatcar-linux/kubernetes/workers/ami.tf
.
@kskewes please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it manually, as we currently don't have a CI process for outside contributions (#1247) and I got the following errors:
module.aws-l8e-mat.data.aws_ami.flatcar: Refreshing state...
Error: Incorrect attribute value type
on ../terraform-modules/aws/flatcar-linux/kubernetes/controllers.tf line 88, in resource "aws_instance" "controllers":
88: ami = local.ami_id
|----------------
| local.ami_id is tuple with 1 element
Inappropriate value for attribute "ami": string required.
Error: Incorrect attribute value type
on ../terraform-modules/aws/flatcar-linux/kubernetes/workers/workers.tf line 58, in resource "aws_launch_configuration" "worker":
58: image_id = local.ami_id
|----------------
| local.ami_id is tuple with 1 element
Inappropriate value for attribute "image_id": string required.
FATA[0010] Applying cluster failed: applying platform: failed checking execution status: exit status 1 args="[]" command="lokoctl cluster apply"
Thanks @kskewes. I'll test this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @kskewes for the work.
closes #1202