This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
docs: Use FLUO to update nodes #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
previously requested changes
Jan 4, 2021
invidian
suggested changes
Jan 4, 2021
surajssd
force-pushed
the
surajssd/add-how-guide-FLUO
branch
from
d9633e7
to
32907c7
Compare
invidian
suggested changes
Jan 5, 2021
surajssd
force-pushed
the
surajssd/add-how-guide-FLUO
branch
from
32907c7
to
6cfada1
Compare
surajssd
force-pushed
the
surajssd/add-how-guide-FLUO
branch
from
6cfada1
to
c044b5e
Compare
iaguis
suggested changes
Feb 17, 2021
There was a problem hiding this comment.
Added some comments.
For some reason I can't comment on threads so I'll answer here.
Well, I think treating components as cluster-agnostic, even when the compatibility is not guaranteed is something valuable. What do you think @iaguis?
In general I don't think we should go out of our way to handle non-Lokomotive clusters, trying to keep that kind of compatibility can lead to expectations so I'd rather be opinionated here.
However, something we should support is managed k8s platforms like AKS, since even though they're managed k8s, they're still Lokomotive clusters.
surajssd
force-pushed
the
surajssd/add-how-guide-FLUO
branch
from
c044b5e
to
b986df1
Compare
invidian
previously approved these changes
Feb 22, 2021
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-how-guide-FLUO
branch
from
b986df1
to
e6e60f4
Compare
iaguis
approved these changes
Feb 23, 2021
surajssd
dismissed
knrt10’s stale review
These suggestions have been incorporated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1260