Lokomotive component azure-arc-onboarding #1473

ipochi · 2021-05-24T08:27:22Z

This PR adds a new Lokomotive component azure-arc-lokomotive for onboarding and removing a Lokomotive cluster from Azure Arc.

To test:
follow the configuration reference documentation for the component.

component azure-arc-lokomotive {
  application_client_id=""
  tenant_id=""
  application_password=""
  resource_group=""
  cluster_name=""
}

lokoctl component apply azure-arc-onboarding

invidian · 2021-05-24T11:00:53Z

Why azure-arc-lokomotive and not azure-arc? We know it's part of Lokomotive :)

invidian

Some thoughts.

assets/charts/components/azure-arc-lokomotive/templates/rbac.yaml

assets/charts/components/azure-arc-lokomotive/templates/register.yaml

assets/charts/components/azure-arc-lokomotive/templates/remove.yaml

pkg/components/azure-arc/component.go

assets/charts/components/azure-arc-lokomotive/templates/register.yaml

assets/charts/components/azure-arc-lokomotive/templates/rbac.yaml

assets/charts/components/azure-arc-lokomotive/Chart.yaml

ipochi · 2021-06-11T12:15:25Z

Why azure-arc-lokomotive and not azure-arc? We know it's part of Lokomotive :)

#1473 (comment)

pkg/components/azure-arc/component.go

pkg/components/azure-arc/image/Dockerfile

assets/charts/components/azure-arc-lokomotive/templates/rbac.yaml

invidian

Not full review, but mainly addressing resolved previous conversations.

pkg/components/azure-arc/component_test.go

invidian

Some smoke review comments

pkg/components/azure-arc/image/script.sh

assets/charts/components/azure-arc-onboarding/templates/register.yaml

assets/charts/components/azure-arc-onboarding/templates/rbac.yaml

assets/charts/components/azure-arc-onboarding/templates/secret.yaml

assets/charts/components/azure-arc-onboarding/templates/remove.yaml

assets/charts/components/azure-arc-onboarding/templates/rbac.yaml

docs/configuration-reference/components/azure-arc-onboarding.md

docs/how-to-guides/azure-arc-onboarding.md

pkg/components/azure-arc-onboarding/component.go

pkg/components/azure-arc-onboarding/image/azure-arc.sh

surajssd

Haven't tried myself, but would love to.

assets/charts/components/azure-arc-onboarding/Chart.yaml

pkg/components/azure-arc-onboarding/image/Dockerfile

pkg/components/azure-arc-onboarding/image/azure-arc.sh

Please re-review

docs/configuration-reference/components/azure-arc-onboarding.md

docs/how-to-guides/azure-arc-onboarding.md

docs/configuration-reference/components/azure-arc-onboarding.md

docs/how-to-guides/azure-arc-onboarding.md

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

invidian

Some minor suggestions

assets/charts/components/azure-arc-onboarding/templates/register.yaml

assets/charts/components/azure-arc-onboarding/templates/remove.yaml

docs/configuration-reference/components/azure-arc-onboarding.md

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

pkg/components/azure-arc-onboarding/component_test.go

surajssd

Few language related changes.

docs/configuration-reference/components/azure-arc-onboarding.md

surajssd · 2021-07-12T12:00:10Z

docs/configuration-reference/components/azure-arc-onboarding.md

+- Delegate access and manage security policies for resources using role-based access control (RBAC) and [Azure
+Lighthouse](https://azure.microsoft.com/en-in/services/azure-lighthouse/).
+
+- Organise and inventory assets through a variety of Azure scopes, such as management groups, subscriptions,


Suggested change

- Organise and inventory assets through a variety of Azure scopes, such as management groups, subscriptions,

- Organise and inventory assets through various Azure scopes, such as management groups, subscriptions,

Microsoft page on Azure arc has a variety of

I added it since it is too wordy. Nothing right or wrong about it.

surajssd · 2021-07-12T12:02:12Z

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

+
+## Learning objectives
+
+At the end of this tutorial you will have onboarded a Lokomotive cluster on Azure Arc, create an Azure Arc


Suggested change

At the end of this tutorial you will have onboarded a Lokomotive cluster on Azure Arc, create an Azure Arc

At the end of this tutorial, you will have onboarded a Lokomotive cluster on Azure Arc, created an Azure Arc

rephrased to

By the end of this guide, the following things would be accomplished: * Onboard a Lokomotive cluster on Azure Arc * Create Azure Arc Kubernetes configuration for the GitOps agent. * Watch the GitOps agent deploy Kubernetes resources from the git repository.

Let me know what you think ?

surajssd · 2021-07-12T12:02:42Z

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

+## Learning objectives
+
+At the end of this tutorial you will have onboarded a Lokomotive cluster on Azure Arc, create an Azure Arc
+Kubernetes configuration and deploy configuration of a sample Nginx Deployment using GitOps.


Suggested change

Kubernetes configuration and deploy configuration of a sample Nginx Deployment using GitOps.

Kubernetes configuration and deployed a sample Nginx Deployment configuration using GitOps.

d61861e#r668465324

surajssd · 2021-07-12T12:03:28Z

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

+- Delegate access and manage security policies for resources using role-based access control (RBAC) and [Azure
+Lighthouse](https://azure.microsoft.com/en-in/services/azure-lighthouse/).
+
+- Organise and inventory assets through a variety of Azure scopes, such as management groups, subscriptions,


Suggested change

- Organise and inventory assets through a variety of Azure scopes, such as management groups, subscriptions,

- Organise and inventory assets through various Azure scopes, such as management groups, subscriptions,

d61861e#r668462275

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

Add a new component `azure-arc-onboarding` that can onboard and remove a Lokomotive cluster in Azure Arc. In its current incarnation, component deploys a Job which executes the commands needed to onboard or remove the Lokomotive cluster from Azure Arc. Signed-off-by: Imran Pochi <imran@kinvolk.io>

This commit adds a Dockerfile that is used to build `az-cli-with-helm` docker image. `azurearc.sh` is executed whenever the pod is created during onboarding/removing the Lokomotive cluster in Azure arc. Versions of `az` and `helm` used are: az - v2.25.0 helm - v3.6.1 Signed-off-by: Imran Pochi <imran@kinvolk.io>

ipochi · 2021-07-13T07:10:51Z

@invidian @surajssd

Added a cleanup section which was forgotten and I have addressed your comments. PTAL.

invidian

Just some remaining nits, otherwise LGTM 👍

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

invidian

LGTM

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md

This commit adds a configuration reference document for the component and a how-to-guide. How-to-guide : GitOps with Azure Arc enabled Lokomotive cluster This How-to guide targets a use case of Deploying configurations using GitOps on an Azure arc enabled Lokomotive cluster. Signed-off-by: Imran Pochi <imran@kinvolk.io>

ipochi requested review from pothos and invidian May 24, 2021 08:27

invidian reviewed May 24, 2021

View reviewed changes

pothos mentioned this pull request May 25, 2021

docs: Azure Arc kinvolk/racker#86

Merged

ipochi force-pushed the imran/azure-arc branch 3 times, most recently from a09dfaa to d637217 Compare June 11, 2021 12:08

ipochi changed the title ~~Lokomotive component azure-arc-lokomotive~~ Lokomotive component azure-arc-onboarding Jun 11, 2021

ipochi requested a review from invidian June 11, 2021 12:15

invidian reviewed Jun 11, 2021

View reviewed changes

pkg/components/azure-arc/component_test.go Outdated Show resolved Hide resolved

pkg/components/azure-arc/component_test.go Outdated Show resolved Hide resolved

invidian reviewed Jun 18, 2021

View reviewed changes

ipochi force-pushed the imran/azure-arc branch 4 times, most recently from 0460a52 to 6105859 Compare June 24, 2021 11:55

invidian reviewed Jun 24, 2021

View reviewed changes

surajssd previously requested changes Jun 24, 2021

View reviewed changes

ipochi force-pushed the imran/azure-arc branch from 6105859 to b130d4e Compare June 25, 2021 12:23

ipochi requested a review from invidian June 25, 2021 13:06

ipochi force-pushed the imran/azure-arc branch from b130d4e to 709098c Compare June 25, 2021 15:11

ipochi requested a review from surajssd June 25, 2021 15:11

surajssd reviewed Jun 28, 2021

View reviewed changes

docs/configuration-reference/components/azure-arc-onboarding.md Outdated Show resolved Hide resolved

surajssd reviewed Jun 28, 2021

View reviewed changes

docs/configuration-reference/components/azure-arc-onboarding.md Outdated Show resolved Hide resolved

invidian reviewed Jun 28, 2021

View reviewed changes

surajssd reviewed Jun 29, 2021

View reviewed changes

docs/configuration-reference/components/azure-arc-onboarding.md Outdated Show resolved Hide resolved

surajssd reviewed Jun 29, 2021

View reviewed changes

docs/how-to-guides/azure-arc-onboarding.md Outdated Show resolved Hide resolved

ipochi force-pushed the imran/azure-arc branch from 709098c to 3d24eba Compare July 3, 2021 11:17

ipochi force-pushed the imran/azure-arc branch 3 times, most recently from 0abab4a to d61861e Compare July 12, 2021 07:57

ipochi commented Jul 12, 2021

View reviewed changes

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md Show resolved Hide resolved

ipochi requested review from surajssd and invidian July 12, 2021 10:00

invidian reviewed Jul 12, 2021

View reviewed changes

surajssd suggested changes Jul 12, 2021

View reviewed changes

ipochi added 2 commits July 13, 2021 11:52

ipochi force-pushed the imran/azure-arc branch from d61861e to 85cfb5a Compare July 13, 2021 07:10

ipochi requested review from invidian and surajssd July 13, 2021 07:10

invidian reviewed Jul 13, 2021

View reviewed changes

ipochi force-pushed the imran/azure-arc branch from 85cfb5a to e96d396 Compare July 13, 2021 09:14

ipochi requested a review from invidian July 13, 2021 09:14

invidian previously approved these changes Jul 13, 2021

View reviewed changes

docs/how-to-guides/gitops-using-azure-arc-onboarding-component.md Outdated Show resolved Hide resolved

ipochi dismissed invidian’s stale review via 8d3cf78 July 13, 2021 09:18

ipochi force-pushed the imran/azure-arc branch from e96d396 to 8d3cf78 Compare July 13, 2021 09:18

ipochi requested a review from invidian July 13, 2021 09:18

invidian approved these changes Jul 13, 2021

View reviewed changes

surajssd approved these changes Jul 13, 2021

View reviewed changes

ipochi merged commit b50a724 into master Jul 13, 2021

ipochi deleted the imran/azure-arc branch July 13, 2021 13:10

ipochi mentioned this pull request Jul 14, 2021

New component for onboarding a Lokomotive cluster in Azure Arc #1497

Closed

invidian added this to the v0.9.0 milestone Jul 16, 2021

invidian added the area/components Items related to components label Jul 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lokomotive component azure-arc-onboarding #1473

Lokomotive component azure-arc-onboarding #1473

ipochi commented May 24, 2021 •

edited

Loading

invidian commented May 24, 2021 •

edited

Loading

invidian left a comment

ipochi commented Jun 11, 2021

invidian left a comment

invidian left a comment

surajssd left a comment

invidian left a comment

surajssd left a comment

surajssd Jul 12, 2021

ipochi Jul 13, 2021

surajssd Jul 13, 2021

surajssd Jul 12, 2021

ipochi Jul 13, 2021 •

edited

Loading

surajssd Jul 12, 2021

ipochi Jul 13, 2021

surajssd Jul 12, 2021

ipochi Jul 13, 2021

ipochi commented Jul 13, 2021

invidian left a comment

invidian left a comment

	- Organise and inventory assets through a variety of Azure scopes, such as management groups, subscriptions,
	- Organise and inventory assets through various Azure scopes, such as management groups, subscriptions,


		## Learning objectives

		At the end of this tutorial you will have onboarded a Lokomotive cluster on Azure Arc, create an Azure Arc

	At the end of this tutorial you will have onboarded a Lokomotive cluster on Azure Arc, create an Azure Arc
	At the end of this tutorial, you will have onboarded a Lokomotive cluster on Azure Arc, created an Azure Arc

	Kubernetes configuration and deploy configuration of a sample Nginx Deployment using GitOps.
	Kubernetes configuration and deployed a sample Nginx Deployment configuration using GitOps.

Lokomotive component azure-arc-onboarding #1473

Lokomotive component azure-arc-onboarding #1473

Conversation

ipochi commented May 24, 2021 • edited Loading

invidian commented May 24, 2021 • edited Loading

invidian left a comment

Choose a reason for hiding this comment

ipochi commented Jun 11, 2021

invidian left a comment

Choose a reason for hiding this comment

invidian left a comment

Choose a reason for hiding this comment

surajssd left a comment

Choose a reason for hiding this comment

invidian left a comment

Choose a reason for hiding this comment

surajssd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ipochi Jul 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ipochi commented Jul 13, 2021

invidian left a comment

Choose a reason for hiding this comment

invidian left a comment

Choose a reason for hiding this comment

ipochi commented May 24, 2021 •

edited

Loading

invidian commented May 24, 2021 •

edited

Loading

ipochi Jul 13, 2021 •

edited

Loading