Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

contour: Update to v1.16.0 #1508

Merged
merged 3 commits into from
Jun 30, 2021
Merged

contour: Update to v1.16.0 #1508

merged 3 commits into from
Jun 30, 2021

Conversation

surajssd
Copy link
Member

Release Notes:
https://github.com/projectcontour/contour/releases/tag/v1.16.0.


Update

kubectl apply -f https://raw.githubusercontent.com/projectcontour/contour/v1.16.0/examples/contour/01-crds.yaml
lokoctl component apply contour

@surajssd
Copy link
Member Author

Something is removing the labels from the calico-system namespace:

=== RUN   TestAllNamespacesHaveNameLabels
    util.go:96: using KUBECONFIG=/root/lokoctl-assets/cluster-assets/auth/kubeconfig
    namespaces_labels_test.go:42: testing namespace "calico-system"
    namespaces_labels_test.go:50: expected "calico-system", got: ""
--- FAIL: TestAllNamespacesHaveNameLabels (0.60s)

@invidian any pointers?

@invidian
Copy link
Member

Why do we even test calico-system namespace? 🤔

@surajssd
Copy link
Member Author

Why do we even test calico-system namespace? thinking

We just list all the namespaces, exclude the test ones and then do the verification. So we don't have an exclude list per se.

@invidian
Copy link
Member

Who creates calico-system namespace then? I don't see any references to it in the source code.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Release Notes:
https://github.com/projectcontour/contour/releases/tag/v1.16.0.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd
Copy link
Member Author

Who creates calico-system namespace then? I don't see any references to it in the source code.

AKS does! I can see all the images in there are from mcr.

@invidian
Copy link
Member

I guess we can just test the namespaces we use then.

@surajssd surajssd force-pushed the surajssd/update-contour-1.16 branch from 0438258 to 953fa80 Compare June 28, 2021 13:44
@surajssd surajssd force-pushed the surajssd/update-contour-1.16 branch from 953fa80 to 2f53355 Compare June 29, 2021 09:57
This commit adds a check to ignore system namespaces like
`calico-system` which is created by AKS.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/update-contour-1.16 branch from 2f53355 to 5983dba Compare June 29, 2021 10:47
@surajssd surajssd merged commit a33519e into master Jun 30, 2021
@surajssd surajssd deleted the surajssd/update-contour-1.16 branch June 30, 2021 11:36
@invidian invidian added area/components Items related to components area/dependency-update To label pending updates of upstream projects labels Jul 16, 2021
@invidian invidian added this to the v0.9.0 milestone Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/components Items related to components area/dependency-update To label pending updates of upstream projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants