Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

pkg/components/util: improvements #605

Merged
merged 4 commits into from
Jun 16, 2020
Merged

pkg/components/util: improvements #605

merged 4 commits into from
Jun 16, 2020

Commits on Jun 16, 2020

  1. pkg/k8sutil: remove unused GetKubernetesObjectFromTmpl function 

    Part of #290

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
    @invidian
    invidian committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    40604c6 View commit details
    Browse the repository at this point in the history

  2. pkg/components/util: merge InstallAsRelease into InstallComponent 

    Previously, we had InstallAsRelease and InstallManifests to be able to
conditionally install components using Helm and InstallComponent was a
wrapper on those 2 functions, controlling this functionality.

Now all components are being installed using Helm, so we no longer need
InstallAsRelease, so it can be merged into InstallComponent function.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
    @invidian
    invidian committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b180cfd View commit details
    Browse the repository at this point in the history

  3. pkg/components/util: use Metadata().Name in chartFromComponent 

    Now that we have component name available in metadata, we no longer need
to pass it explicitly to this function.

Part of #266

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
    @invidian
    invidian committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7325ce8 View commit details
    Browse the repository at this point in the history

  4. pkg/components/util: refactor InstallComponent to make it shorter 

    This commit moves ensuring that release namespace exists code into
separate function, so linter does not complain about function length and
potentially allows to test this bit of code independently.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
    @invidian
    invidian committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5e69aac View commit details
    Browse the repository at this point in the history