This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
previously approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some change for manifests in this release?
surajssd
force-pushed
the
surajssd/update-calico-3.15.0
branch
from
June 22, 2020 11:10
14242cd
to
096d129
Compare
invidian
reviewed
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions/nits, otherwise LGTM
assets/lokomotive-kubernetes/bootkube/resources/charts/calico/templates/deployment.yaml
Show resolved
Hide resolved
surajssd
force-pushed
the
surajssd/update-calico-3.15.0
branch
from
June 23, 2020 08:04
6972b65
to
94293ae
Compare
surajssd
force-pushed
the
surajssd/update-calico-3.15.0
branch
3 times, most recently
from
June 23, 2020 16:06
73e3d8a
to
0bf9d41
Compare
surajssd
force-pushed
the
surajssd/update-calico-3.15.0
branch
4 times, most recently
from
June 24, 2020 07:51
093317f
to
c8eddca
Compare
Release notes: https://docs.projectcalico.org/release-notes/#v3150 Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
- Add new var in the chart `flexvolDriverImage`. - Since `ipipReadiness`'s default value is already included in configs now, there is no need of providing that var. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This commit adds a mandatory field in FelixConfiguration `bpfLogLevel`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-calico-3.15.0
branch
4 times, most recently
from
June 24, 2020 18:30
54e24a6
to
8862a7f
Compare
Mount CNI dir `/etc/cni/net.d` in kubelet. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-calico-3.15.0
branch
from
June 25, 2020 04:30
8862a7f
to
e89ab99
Compare
iaguis
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://docs.projectcalico.org/release-notes/#v3150