-
Notifications
You must be signed in to change notification settings - Fork 49
docs/development: add section about codespell #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @invidian. Some small change, rest it looks good to me.
docs/development/README.md
Outdated
|
||
To check for typos in commit messages of your feature branch, you can run the following command: | ||
```sh | ||
git diff master..HEAD | grep -v ^- | codespell - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work? AFAIK git diff
doesn't show commit messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I copied the wrong command from my script 😄 It suppose to be git log master..HEAD | codespell -
:)
Closes #691 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
94cf9cc
to
fe89ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @invidian. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #691
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io