-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too many hydrate actions get dispatched #496
Labels
Comments
This was referenced Nov 2, 2022
Closed
kirill-konshin
added a commit
that referenced
this issue
Dec 28, 2022
* Use useMemo for hydration and avoid unnecessary hydrates (#502) * Upgrade packages and refactor a bit * Added necessary testing dependency * Stop hydrating on server and use useLayoutEffect for client hydration * Added pokemon page with rtk's createApi * Added back dispatch in GSP in demo repo * A change in query params constitutes a new page now * Improve performance by using another hook on server * Add detail page * New approach: split gsp and gssp and hydrate based on those * Added a second type of initial state handling with more explanations * Improved useMemo comment * Make sure hydrates work when staying on the same page * Add links to demo repo to test issue (seems like no issue) * Proper gipp fix (#512) * ESLint fix * Gipp testcase and example page in RTK repo (#514) * Add GIP to _app and add GIP in page to RTK repo * Added e2e test for RTK repo * Added testcase for GIAP and GIPP to wrapper * Consistent casing and formatting in comments Fix #493 #495 #496 Co-authored-by: voinik <victor_panteleev@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When in
_app.tsx
usingwrapper.getInitialAppProps
and in a pagewrapper.getServerSideProps
too many hydrate actions get dispatched causing the client component to re-render unnecessary.On one page load 4
__NEXT_REDUX_WRAPPER_HYDRATE__
actions are dispatched in the client store.To Reproduce
Please see: https://github.com/karaoak/nrw and https://nrw.vercel.app/foo for a working demo (use Chrome Redux Devtools to see what's happening).
Steps to reproduce the behavior:
Expected behavior
Only one Hydrate action per server request should take place.
Screenshots
Desktop (please complete the following information):
Additional context
Not using
wrapper.getInitialAppProps
and only usewrapper.getServerSideProps
does not result in this issue.If enabling in
reactStrictMode
next.config.js
the problem gets worse: 8 hydrate actions get dispatched 🤷♂️The text was updated successfully, but these errors were encountered: