Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Response Headers #908

Merged
merged 8 commits into from
May 21, 2024
Merged

Implement Response Headers #908

merged 8 commits into from
May 21, 2024

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented May 20, 2024

When I looked at Coil Alpha for the network modules, I noticed they use request and response for headers. Also, it would be useful for developers to inspect the HTTP Headers in their app too.

@iNoles iNoles self-assigned this May 20, 2024
@iNoles iNoles requested a review from kittinunf May 20, 2024 03:09
@kittinunf
Copy link
Owner

Nice! Do you think we should add some tests to cover these?

@iNoles
Copy link
Collaborator Author

iNoles commented May 20, 2024

Nice! Do you think we should add some tests to cover these?

Sure, I can do that when I get a chance to do it.

Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Let's do this

@iNoles iNoles merged commit 1a716f5 into main May 21, 2024
7 checks passed
@iNoles iNoles deleted the headers branch May 21, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants